Skip to content

AddOp(upsample_trilinear3d) | feat(torchlib)#1260

Merged
justinchuby merged 1 commit intomainfrom
xiaowu/addOp(upsample_trilinear3d)
Jan 29, 2024
Merged

AddOp(upsample_trilinear3d) | feat(torchlib)#1260
justinchuby merged 1 commit intomainfrom
xiaowu/addOp(upsample_trilinear3d)

Conversation

@xiaowuhu
Copy link
Copy Markdown
Contributor

@xiaowuhu xiaowuhu commented Jan 29, 2024

No description provided.

@xiaowuhu xiaowuhu added the module: torchlib Related to the torch/aten function lib in development label Jan 29, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a7ae80) 78.87% compared to head (efbd732) 78.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
+ Coverage   78.87%   78.88%   +0.01%     
==========================================
  Files         119      119              
  Lines       15692    15715      +23     
  Branches     2479     2482       +3     
==========================================
+ Hits        12377    12397      +20     
- Misses       2906     2910       +4     
+ Partials      409      408       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 29, 2024

Test Results

     24 files  +     1      24 suites  +1   1h 40m 12s ⏱️ +45s
 11 421 tests +     3   8 448 ✅ +    4    2 961 💤 ±     0   12 ❌  - 1 
258 150 runs  +16 839  58 716 ✅ +4 254  199 242 💤 +12 587  192 ❌  - 2 

For more details on these failures, see this check.

Results for commit efbd732. ± Comparison against base commit 9a7ae80.

This pull request removes 22 and adds 25 tests. Note that renamed tests count towards both. 
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_331_aten_upsample_nearest2d
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_332_aten_ones_like
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_333_aten_roll
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_334_aten_roll_complex
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_335_aten_scatter_reduce
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_336_aten_slice_scatter
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_337_aten_slice
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_338_aten_stft
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_339_aten_sum_dim_IntList
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_340_aten_tensor_bool
…

onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_331_aten_upsample_trilinear3d
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_332_aten_upsample_nearest2d
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_333_aten_ones_like
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_334_aten_roll
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_335_aten_roll_complex
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_336_aten_scatter_reduce
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_337_aten_slice_scatter
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_338_aten_slice
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_339_aten_stft
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_340_aten_sum_dim_IntList
…

@xiaowuhu xiaowuhu mentioned this pull request Jan 29, 2024
Closed
8 tasks
@justinchuby justinchuby merged commit 670dbfa into main Jan 29, 2024
@justinchuby justinchuby deleted the xiaowu/addOp(upsample_trilinear3d) branch January 29, 2024 14:49
@liqunfu liqunfu mentioned this pull request Feb 6, 2024
Closed
Copilot AI mentioned this pull request Jun 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees

No one assigned

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

ONNX Script Review Board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xiaowuhu @justinchuby
⚡